Amulet-Team / Amulet-Map-Editor

A new Minecraft world editor and converter that supports all versions since Java 1.12 and Bedrock 1.7.
https://www.amuletmc.com/
1.79k stars 123 forks source link

[Bug Report] Missing Textures and Block State Errors in Bedrock 1.20/1.21 #1090

Open StealthyExpertX opened 3 months ago

StealthyExpertX commented 3 months ago

Bug Report

Current Behaviour:

While testing my set loot tables script, I noticed issues with some new blocks introduced in Minecraft Bedrock 1.20.0 and 1.21.0 updates. Specifically, heavy cores and decorated pots are missing textures in Amulet. Additionally, I'm experiencing block state issues with chiseled bookshelves.

Error Message:

ERROR - Failed to parse block state for minecraft
facing="west",slot_0_occupied="false",slot_1_occupied="false",slot_2_occupied="false",slot_3_occupied="false",slot_4_occupied="false",slot_5_occupied="false"
Could not parse state val [{'facing': 'west'}, {'slot_5_occupied': 'false'}]

The chiseled bookshelves are also missing some texture faces entirely.

Expected Behavior:

All blocks, including heavy cores, decorated pots, and chiseled bookshelves, should display correctly in Amulet without missing textures or block state errors in the console.

Steps To Reproduce:

  1. Place new blocks (heavy cores, decorated pots, chiseled bookshelves) from the creative inventory or using /setblock commands in Minecraft Bedrock 1.20.0 or 1.21.0.
  2. Save and exit the game.
  3. Load the world into Amulet.
  4. View the blocks in 3D and check the console for errors.

Environment:

Additional Context:

This issue was encountered after placing every block from the creative inventory and via /setblock commands, then loading the world into Amulet. The textures were missing, and the console displayed many of the above errors.

Attachments

Screenshots

image

gentlegiantJGC commented 3 months ago

Decorated pots don't have a model in the Java resource pack. It just be done with code. Fancy submitting a model? https://github.com/gentlegiantJGC/Minecraft-Model-Reader/tree/master/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix

The chiselled bookshelf error was reported in #1021 but I had forgotten about it.

Not sure currently what is breaking the heavy core.

gentlegiantJGC commented 3 months ago

That was a miss-click.

I have looked into the heavy core rendering issue. There must be something I am misunderstanding. Textures are usually looked up like this

{
    "textures": {
        "all": "block/bamboo_stalk",
        "particle": "block/bamboo_stalk"
    },
    "elements": [
        {   "from": [ 6.5, 0, 6.5 ],
            "to": [ 9.5, 16, 9.5 ],
            "faces": {
                "down":  { "uv": [ 13, 4, 16, 7 ], "texture": "#all", "cullface": "down" },
                "up":    { "uv": [ 13, 0, 16, 3 ], "texture": "#all", "cullface": "up" },
                "north": { "uv": [ 3, 0, 6, 16 ], "texture": "#all" },
                "south": { "uv": [ 3, 0, 6, 16 ], "texture": "#all" },
                "west":  { "uv": [  3, 0, 6, 16 ], "texture": "#all" },
                "east":  { "uv": [  3, 0, 6, 16 ], "texture": "#all" }
            }
        }
    ]
}

but the heavy core looks like this

{
  ...
  "textures": {
    "all": "block/heavy_core",
    "particle": "block/heavy_core"
  },
  "elements": [
    {
      "name": "heavy_core",
      "from": [4, 0, 4],
      "to": [12, 8, 12],
      "faces": {
        "north": {"uv": [0, 8, 8, 16], "texture": "all"},
        "east": {"uv": [0, 8, 8, 16], "texture": "all"},
        "south": {"uv": [0, 8, 8, 16], "texture": "all"},
        "west": {"uv": [0, 8, 8, 16], "texture": "all"},
        "up": {"uv": [0, 0, 8, 8], "texture": "all"},
        "down": {"uv": [8, 0, 16, 8], "texture": "all"}
      }
    }
  ]
}

Since there isn't a # at the start it is being looked up as an embedded path.