search

AnIML / techniques

AnIML Technique Definitions
17 stars 7 forks source link

chromatography-peak-table: Fix lineendings, fix wrong property value #20

Closed laeubi closed 2 years ago

laeubi commented 2 years ago

Currently the chromatography-peak-table uses macintosh line endings (\r) while all other atdd files using windows-line endings (\r\n). And while the xml processing tools don't complain, at least the github UI shows strange red ^M characters

Beside that there was an erroneous attribute in the specification the xml-validation of this technique fails with:

SAXParseException; systemId: chromatography-peak-table.atdd; lineNumber: 770; columnNumber: 114; cvc-enumeration-valid: Value 'dependency' is not facet-valid with respect to enumeration '[independent, dependent]'. It must be a value from the enumeration.

Mailaender commented 2 years ago

I suggest to depend this on https://github.com/AnIML/techniques/pull/18 so that the actual change is visible.

laeubi commented 2 years ago

I suggest to depend this on #18 so that the actual change is visible.

I simply split this one into two commits you can see the indivdual diffs here

  1. Line Endings: https://github.com/AnIML/techniques/pull/20/commits/86d04db6178f6683b40204aa6b29b1636448b7ed
  2. Wrong Attribute: https://github.com/AnIML/techniques/pull/20/commits/56c31b502456f708403ac6605eb39f0bc6175cfc