AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

fix(ci): apple certs not installed on prod #561

Closed marfavi closed 6 months ago

marfavi commented 6 months ago

this PR will change the build_ios action to always install certificates and provisioning profiles, instead of only doing so for development builds.

ghost commented 6 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/561/b296cf0c/c6017b91ad39b4ff0d8f6d8a524ef6392d0fbf1e.svg)](https://app.codesee.io/r/reviews?pr=561&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend CodeSee Map legend
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c3a9b21) 72.36% compared to head (c6017b9) 72.36%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #561 +/- ## ======================================= Coverage 72.36% 72.36% ======================================= Files 133 133 Lines 1603 1603 ======================================= Hits 1160 1160 Misses 443 443 ``` | [Flag](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/561/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/561/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | `72.36% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.