search

AndrewAnnex / planetcantile

tile matrix sets for other planets
BSD 3-Clause "New" or "Revised" License
9 stars 1 forks source link

Fixes #14: Adds _geographic_crs #15

Closed jlaura closed 1 year ago

jlaura commented 1 year ago

This PR simplifies the read/write on the TMS as JSON and adds support for encoding the _geographic_crs key. See #14 for a description of why this field is needed.

AndrewAnnex commented 1 year ago

@jlaura looking at this a bit harder, this may actually really be a bug with morecantile's parsing of the files and the init method for tilematrixset. Within the for-loop in planetcantile the _geographic_crs is correctly set. While updating the json files to include _geographic_crs does work, probably morecantile can/should be updated here https://github.com/developmentseed/morecantile/blob/644d3b70547420222d3c34071f2eb78da0e37646/morecantile/models.py#L162

AndrewAnnex commented 1 year ago

@jlaura mind if I push some fixes to the pr?

jlaura commented 1 year ago

@AndrewAnnex Not at all! I'm wrapping a data release and was hoping to have time at the end of the week. Any attention you have for this is absolutely appreciated!