[Close #15] Resueable modal component

Andrewnt219 / rent-near-me

https://rent-near-me.vercel.app/

1 stars 1 forks source link

[Close #15] Resueable modal component #30

Closed vitokhangnguyen closed 3 years ago

vitokhangnguyen commented 3 years ago

Close #15

To do:

[ ] Accessiblity labels (aria-describedby and aria-labeledby)
[x] Add scrollable header and body if overflown

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/andrewnt219/rent-near-me/6yHvkbe6SLbEDPoEAAksxSZrMkes
✅ Preview: https://rent-near-me-git-vitokhangnguyen-issue15-andrewnt219.vercel.app

vitokhangnguyen commented 3 years ago

I'll use the ReachUI to fix the accessibility issues.

Some other nice-to-have

[ ] Exit animation (framer-motion).

[ ] Link to sign up if doesn't have an account and vice versa.

Exit animation is omitted by design (Airbnb does not have exit animation) I'm also working on the sign-up link which will close this Modal and open the sign up one.

vitokhangnguyen commented 3 years ago

Accessibility features should be added now with ReachUI. I am still solving other problem.