Refactor: Apply feedbacks from code reviews - Githubissues

Andrewnt219 / rent-near-me

https://rent-near-me.vercel.app/

1 stars 1 forks source link

Refactor: Apply feedbacks from code reviews #69

Closed vitokhangnguyen closed 3 years ago

vitokhangnguyen commented 3 years ago

From #63:

[ ] ~~Create a protected route / page guard mechanism (may become a seperated issue)~~ #71
[x] Change the type of error parameter in getErrorMessage() in src/utils/api-responses.ts to unknwon
[x] Fix typo in ModeLType

From #70:

[x] Refactor modals - making show and onDismiss mandataory props
[x] Refactor useModalGroup - making return ModalControl non-optional type
[x] Move logic of onCreateAccountClick and onAlreadyHaveAccountClick inside the componenets