Andrewthe13th / Inventory_Kamera

Scans Genshin Impact characters, artifacts, and weapons from the game window into a JSON file.
MIT License
699 stars 122 forks source link

Infinite character scanning #429

Closed Tron-Creeper2 closed 1 year ago

Tron-Creeper2 commented 1 year ago

Current Behavior

When scanning characters, after reaching the last character in the list, the scanner will loop back around to the first one and start scanning everything again. I let it run for a while but decided to stop it once it reached 319 characters scanned.

2nd time I was testing it, the same just stopped at 208.

Expected Behavior

The scanner stops scanning

Reproducing a Behavior

Start a scan with the character scan option selected (in my case, had all "scan items" checked) Video proof Screenshot_55

Device OS

Windows 11

Genshin Impact Version

3.4

Inventory Kamera Version

1.3.7

Screen resolution, screen mode, and UI scale

2560x1440 (fullscreen) and 1920x1080 (windowed)

Additional notes and remarks

Evidence

GoogleDrive - bug report + genshinData_GOOD.json YouTube - Video proof

Preflight Checklist

TitaniumLexa commented 1 year ago

As i figured out that's because of Traveler in first slot. Temporary solution is move to another slot or use party without Traveler. Also created pull request with fix.