Decimal values are rounded during the scan

dymm2000 commented 10 months ago

Current Behavior

As described in title. Previous version worked well.

Expected Behavior

The scanner continues to scan

Reproducing a Behavior

Scan

Device OS

Windows 10

Genshin Impact Version

4.4

Inventory Kamera Version

1.3.13

Screen resolution, screen mode, and UI scale

1280x720

Additional notes and remarks

No response

Evidence

Preflight Checklist

[X] I have checked for similar issues in the issue page, and I have not found any similar to mine.
[X] I am using the latest version of the scanner.
[X] I tried setting the scanning delay to maximum, and it still doesn't work.
[ ] I have attached the video recording to the bug report.
[ ] I have attached the error log to the bug report.
[ ] I am available to later explains the issue.
[X] I have disabled all screen filtering software or plugins (i.e. HDR, Image Sharpening) while scanning.
[X] I use default in-game keybindings or have configured keybindings for the scanner.

kylelamse commented 10 months ago

Same problem here. I was going crazy wondering why each decimal point was cut off.

pv42 commented 10 months ago

Might be related to the regular expression change in 5ba2fcedcc62c298ba416af047b8e63fc4e4b752 : InventoryKamera/scraping/ArtifactScraper.cs:451

-    Regex re = new Regex(@"([\w]+\W*)(\d+.*\d+)");
+    Regex re = new Regex(@"^(.*?)(\d+)");

BlueSpaceCanary commented 10 months ago

Might be related to the regular expression change in 5ba2fce : InventoryKamera/scraping/ArtifactScraper.cs:451
-    Regex re = new Regex(@"([\w]+\W*)(\d+.*\d+)");
+    Regex re = new Regex(@"^(.*?)(\d+)");

Yeah, comparing the two matching against the string 15.7, the old regex matches the whole string but the new regex only matches the characters before the decimal place.

kylelamse commented 10 months ago

Reverting that line doesn't seem to fix the problem when testing it locally

Rettilaa commented 10 months ago

Same Issue, numbers after decimal are ignored

exliko commented 10 months ago

up, I have the same problem

BlueSpaceCanary commented 9 months ago

Reverting that line doesn't seem to fix the problem when testing it locally

Reverting both that and the deletion a little further down fixed it for me in a local build

Cupcak3 commented 9 months ago

This is fixed in the latest release

Andrewthe13th / Inventory_Kamera