search

Andrewthe13th / Inventory_Kamera

Scans Genshin Impact characters, artifacts, and weapons from the game window into a JSON file.
MIT License
699 stars 122 forks source link

Revert ArtifactScraper.cs changes #504

Closed cameronetaylor6 closed 9 months ago

cameronetaylor6 commented 9 months ago

Related to #503

Example output files (tested fix by running in Debug mode in Rider, and scanning a subset of my artifacts):

Diff of results (diff before_fix_GOOD.json after_fix_GOOD.json > diff.patch)

Also confirmed that GenshinOptimizer does not show the stats as invalid after uploading post-fix.

I'm not familiar with C# or the intent of the original change, so feel free to push back or give feedback.

kylelamse commented 9 months ago

Confirmed. This change works for me too.

cameronetaylor6 commented 9 months ago

Closing since a better fix has been merged 🎉