Fix various typos - Githubissues

AngelMunoz / Perla

A cross-platform tool for unbundled front-end development that doesn't depend on Node or requires you to install a complex toolchain

https://perla-docs.web.app/

MIT License

131 stars 12 forks source link

Fix various typos #52

Closed mlaily closed 3 years ago

mlaily commented 3 years ago

I spent some time looking around to see how things are put together, and I fixed some minor things along the way...

Things I saw that I didn't fix:

there are still several mentions of fds in the code that should probably be renamed to Perla
I resisted the urge to change all the IArgParserTemplate messages either to imperative (Do xxx) or present (Does ...). I'm not sure which one you prefer but it would probably be nicer to stay consistent.
There is a usage message ("The name of the package to remove from the import map this can also be aliased name.") that looks like it should be two separate sentences.

AngelMunoz commented 3 years ago

Hey there! indeed the original name was "FSharp.DevServer" then I switched to Perla, I changed some of those but not everything, I'm really thankful for these changes

I resisted the urge to change all the IArgParserTemplate messages either to imperative (Do xxx) or present (Does ...). I'm not sure which one you prefer but it would probably be nicer to stay consistent.

I think I'm leaning towards present

There is a usage message ("The name of the package to remove from the import map this can also be aliased name.") that looks like it should be two separate sentences.

How about "Package name or alias to be removed." or something along those lines?

I can merge this PR as is, I like the changes, or do you want to include the other changes as well?

mlaily commented 3 years ago

Let me quickly change the tense of the usage messages if that's ok with you then :)

(and sorry about the target branch, I didn't notice dev)

AngelMunoz commented 3 years ago

Let me quickly change the tense of the usage messages if that's ok with you then :)

Be my guest :)

about the target branch, I didn't notice dev

no worries, I forgot to mention it on the last comment as well

AngelMunoz commented 3 years ago

Thanks for these changes :) I really appreciate them

AngelMunoz commented 3 years ago

hey @mlaily your changes are live in v0.17.0 thanks for contributing!