search

AngellusMortis / django_microsoft_auth

Simple app to enable Microsoft Account, Office 365 and Xbox Live authentcation as a Django authentcation backend.
MIT License
137 stars 84 forks source link

Proxies #448

Closed hazraa closed 3 years ago

hazraa commented 3 years ago

Our use case is a strict outgoing firewall policy. With the many login.microsoftonline.com IPs, a proxy makes sense. We use django-microsoft-auth for staff admin login of our django app which also consumes many external API's and not everything goes via a proxy, so we don't want a blanket proxy config via the app environment like "http_proxy" etc. So passing a proxy down into requests.Sessions solves our use case. Didn't see this option available yet.

AngellusMortis commented 3 years ago

I finally got GHA set up and working. Please sync with master and then fix any CI issues if you would like me to continue with merging the PR.

AngellusMortis commented 3 years ago

If you revert your changes to ci.yml and sync with master again, it should run everything correctly now. Sorry, first time I have really dealt with GHA with OSS forks. It is rather a PITA.

hazraa commented 3 years ago

yeh, just trying to clear CI errors on my local "proxies" branch with that tmp change. Did add a local CodeClimate CC_TEST_REPORTER_ID in the env, I see its hardwired now.

black maybe complaing about: tests/test_client.py: Python script, ASCII text executable, with CRLF line terminators Other py files seems to 'normal' eg:   microsoft_auth/urls.py: Python script, ASCII text executable

harry

On 10/11/21 2:15 pm, Christopher Bailey wrote:

If you revert your changes to |ci.yml| and sync with master again, it should run everything correctly now. Sorry, first time I have really dealt with GHA with OSS forks. It is rather a PITA.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AngellusMortis/django_microsoft_auth/pull/448#issuecomment-964748193, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJBBDS6L3DUM7XZQYMDLSTULHPVJANCNFSM4ZBUVVDA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

AngellusMortis commented 3 years ago

For black/formatting, you should just need to make sure you have the dev reqs installed (pip install -r reqs/dev requirements.txt) then run .bin/format-code. Or just black . from the git repo root.

You can ignore the 1 CC linting error. I can refractor that later.