AniTrend / anitrend-v2

Rewrite project for AniTrend 🔥
GNU General Public License v3.0
45 stars 6 forks source link

[design] Fix view pager inside of bottom sheet dialgog #79

Closed wax911 closed 1 year ago

wax911 commented 2 years ago

AniTrend Issue Guidelines

Before opening a new issue, please take a moment to review our community guidelines to make the contribution process easy and effective for everyone involved.

You may find an answer in already closed issues: https://github.com/AniTrend/anitrend-v2/issues?q=is%3Aissue+is%3Aclosed

Description of Bug

We have a tabbed bottom sheet using a ViewPager2 and a combination of child elements for each page. It seems like there are some issues with sizing (child nested scroll views will stop scrolling after another tab is inflated)

Reproduction Steps

Maybe linked to https://github.com/material-components/material-components-android/issues/2112

Additional Context

We may have to revert to the standard ViewPager instead of ViewPager2. See: eu.kanade.tachiyomi.widget.TabbedBottomSheetDialog for suggestions

An alternative is to rebuild this particular component in compose fashion

wax911 commented 1 year ago

We'll migrate this over to compose, safely closing this off