Anime-Game-Servers / Grasscutter-Quests

A server software implementation, ineroperable with a certain anime game client. The code in this repository is fully custom made for edyoucational purposes and future preservation, no copyrighted code is allowed in this repository.
https://grasscutters.xyz/grasscutter
GNU Affero General Public License v3.0
138 stars 31 forks source link

link AddBlossomScheduleProgressByGroupId to addBlossomProgress #115

Closed scooterboo closed 9 months ago

scooterboo commented 9 months ago

Description

When interacting with Ley Line Outcrops, a Defeat all opponents 0/7 notif appears, but defeating all of the enemies does nothing.

image

I quickly found that unimplemented ScriptLibHander.AddBlossomScheduleProgressByGroupId was being called every time a monster was defeated and that BlossomManager had a unused function addBlossomProgress with the note: Update Blossom camp's progress (on monster die for example), triggered by ScriptLib. I noticed by looking at the lua that if only a EVENT_BLOSSOM_PROGRESS_FINISH was called, the group's sequence could continue. addBlossomProgress has a EVENT_BLOSSOM_PROGRESS_FINISH in it. I'm pretty sure linking these up is the right thing to do.

After linking them up, progress happened correctly!

image

Type of changes

Checklist:

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud