Anime-Game-Servers / Grasscutter-Quests

A server software implementation, ineroperable with a certain anime game client. The code in this repository is fully custom made for edyoucational purposes and future preservation, no copyrighted code is allowed in this repository.
https://grasscutters.xyz/grasscutter
GNU Affero General Public License v3.0
138 stars 31 forks source link

Grid and gadget ability optimisations and fixes #63

Closed StartForKiller closed 1 year ago

StartForKiller commented 1 year ago

Description

This PR adds basic support for gadget abilities, solves a cache problem on entity grid and adds dev key Also this PR(new) optimizes the group loading check

Issues fixed by this PR

Type of changes

Checklist:

eternalcomet commented 1 year ago

https://github.com/Anime-Game-Servers/Grasscutter-Quests/blob/769abcfb9855367e7d3a73cd6b19801f23f659a4/src/main/java/emu/grasscutter/scripts/SceneScriptManager.java#L383 maybe we should remove this for static field

StartForKiller commented 1 year ago

https://github.com/Anime-Game-Servers/Grasscutter-Quests/blob/769abcfb9855367e7d3a73cd6b19801f23f659a4/src/main/java/emu/grasscutter/scripts/SceneScriptManager.java#L383

maybe we should remove this for static field

You are seeing old code

eternalcomet commented 1 year ago

@Hartie95 has refactored binout EntityConfig loading, so your branch has conflicts to be solved. See https://github.com/Anime-Game-Servers/Grasscutter-Quests/commit/9f6568c791c782c0d6e0bf68eeb6c980f9826439 , he moved and refactored some binout class.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 67 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication