Annosz / UIInfoSuite2

Ongoing maintenance for the original UI Info Suite mod for Stardew Valley.
1.57k stars 290 forks source link

[Minor Mod Incompatibility]: QuickSave #585

Open DeLiXx opened 4 months ago

DeLiXx commented 4 months ago

Mod Version

v2.3.4

Multiplayer

Single Player

Visual Settings

100% 100%

SMAPI Log

No response

Description

Hello! Unfortunately when loading a savefile in the middle of the day using QuickSave some UI elements like the daily luck symbol and tomorrows weather duplicate. It'd be great if mod compatibility could be established. To reproduce just create a new game with both mods installed. Press F5 to quicksave and F7 to quickload.

image

wulingxuan commented 3 months ago

This has to do with how the mod is loaded. If the mod data is loaded when the archive is loaded and the mod data is unloaded when the return menu, this phenomenon will occur when the QuickSave is used, the old mod data is not unloaded but the mod data is loaded again when the new archive is loaded. If QuickSave can be triggered when loading the archive (helper.Events.GameLoop.ReturnedToTitle) should be able to solve the problem, or ui2 add IQuickSaveAPI.LoadingDelegate Dispose.

See new and Dispose.

wulingxuan commented 1 week ago

Fix #630.