search

Anthonyy232 / Paperize

Paperize is a modern dynamic wallpaper changer application built for Android using Kotlin, Jetpack Compose, and Material 3
https://anthonyy232.github.io/Paperize/
GNU General Public License v3.0
410 stars 17 forks source link

[Bug] F-Droid reproducible build failed #190

Open linsui opened 1 day ago

linsui commented 1 day ago

https://gitlab.com/fdroid/fdroiddata/-/jobs/8058432296

Somehow aboutlibraries doesn't work in your build. Could you please take a look? Thanks!

Anthonyy232 commented 21 hours ago

I believe it's fixed in v2.3.1, let me know.

linsui commented 10 hours ago

2024-10-12 04:31:15,913 ERROR: Could not build app com.anthonyla.paperize: Unexpected version/version code in output; APK: 'paperize-vproperty(java.lang.String, map(java.lang.String provider(?) check-type()))' / '33', Expected: '2.3.1' / '33'

The version name is broken...

Anthonyy232 commented 9 hours ago

Is this incorrect? image

Maybe there's was a weird cache error, I'll replace the APK in the release I guess

linsui commented 8 hours ago

Your apk is correct. But my build has the broken version name. Any idea?

Anthonyy232 commented 8 hours ago

Not really sure. Some things I changed this release were: JDK to 17 NDK to 28.0.12433566 BuildTools to 35.0.0

Lastly, maybe this?

applicationVariants.all {
        this.outputs
            .map { it as com.android.build.gradle.internal.api.ApkVariantOutputImpl }
            .forEach { output ->
                val apkName = "paperize-v${this.versionName}.apk"
                output.outputFileName = apkName
            }
    }

It's not immediately obvious to me that this would be the issue, but I can try rolling that part back. What do you think?

Edit** Actually seems like I forgot to push something. Are you able to test it based on the latest code in the main branch, or do I need to make a new release?

Edit** I'm pretty sure I might've fixed the issue and can make a new release perhaps?

linsui commented 8 hours ago

Yes, I thought it caused by this. Will test it soon. :)

linsui commented 8 hours ago

The version name issue is fixed but the apk is not reproducible.

https://gitlab.com/linsui/fdroiddata/-/jobs/8068812928 Your apk is built from the old commit. And could you please downgrade the ndk to a stable version? We can't use a beta version.

Anthonyy232 commented 8 hours ago

Sure. I'll do that tomorrow

Edit** Done