search

AntoPISA / MAME_SupportFiles

MAME Support Files (category, catver, series, version, etc.)
https://www.progettosnaps.net/
9 stars 2 forks source link

renameSET mistakes #49

Closed ghost closed 1 month ago

ghost commented 2 months ago

Thanks for your work on renameSET but unfortunately you trust buggy UI of MAME :) Everything below is calculated WITHOUT BIOS and devices, as you do too. We are talking then about 40608 machines in MAME 0.270

MAIN LIST:

Following things are wrong, the first caused by bugs in the MAME UI:

0/180 degrees = hor 90/270 = vert

You get this result:

I don't know why you have a slightly different result. If you apply this method, you get these numbers. Maybe you don't use all screens? I think you need to use all screens because multi-screen machines can have different oriented screens. If one of the screens is hor/vert then you should count that too because multi-screen machines don't have a main screen: the screens are equal to each other and you can't ignore the 2nd, 3rd, ... screen. There is room to discuss here :)

This is math too and can't be discussed. My sum gives me the 40608 machines: 13936 + 26672 = 40608

Your sum gives another wrong result: 14012 + 26672 = 40684

I'm afraid these specific statistics are wrong for each MAME version since you always apply the same method. So the +/- are wrong too :(

My sum is correct: 15638 + 24970 = 40608 Your sum doesn't give 40608...

SOFTWARE LISTS:

I let my program kick my ass when the math is wrong :) So then I know I made a bug. So far, all math is correct.

I strongly suggest doing math: you find your own mistakes this way I'm afraid all your previous calculations are also wrong and comparing wrong results with previous wrong results are ...also wrong :( So not sure what you will do now. You need to start from zero to fix this...

PS: I can you give you the exact lists if you want. I did not check everything you counted.

ghost commented 2 months ago

This is not a negative comment, I just wanted to report this because all future calculations using your same methods will be wrong too.

You can quickly re-count everything by making a tool and feeding it all the Mame XML files on your website. You have them all I see.

AntoPISA commented 1 month ago

Following things are wrong, the first caused by bugs in the MAME UI:

CHD: "1.202 requires CHDs" 1202 reported by MAME. In reality it's 1192. It's a bug in MAME. You can count yourself...

-> You have already given the answer: the MAME is currently wrong, when they correct I will too.

screen: "18.145 horizontal screen (+41), 3.221 vertical screen (+1)" I thank God you don't use MAME for this: it's HORRIBLY wrong because they even count machines WITHOUT a screen. This is a HUGE bug.

0/180 degrees = hor 90/270 = vert

You get this result:

hor: 18451 vert: 3224 ...

-> These counts have long been a cause for discussion; I hope in the future to resolve this issue.

driver: "3.074 drivers (+14)" There are 3071 drivers if you remove BIOS and devices (which you do because you have 40608 machines)

-> This count actually doesn't add up for me either: it shows 3.069 to me.... I will investigate (and talk to the programmer about it).

parents: "14.012 parents (+29)" There are 13936 parents

My sum gives me the 40608 machines: 13936 + 26672 = 40608

Your sum gives another wrong result: 14012 + 26672 = 40684

-> You forgot the 76 "BIOSes" that are added to the "Parents" (although this sum is under discussion and may be changed in the future).

mechanical: "25.046 not mechanicals (+50)" There are 24970 not mechanicals My sum is correct: 15638 + 24970 = 40608 Your sum doesn't give 40608...

-> You forgot the 76 "BIOSes" (and again I remind you that this, wrong or not, is the figure reported by MAME).

samples: "595 sample files" There are only 355 different sample files

-> I don't know if you have the complete set of Samples... I have it and there are 595 files (in 77 packages).

supported: "97.824 supported software (+92), 1.800 partially supported software (+9), 38.761 unsupported software (+9)" There are 97100 supported, 1800 partial supported and 38724 not supported. My sum 97100 + 1800 + 38724 = 137624, which is the total number of software list games

-> You are not calculating the "orphan" lists in the \hash folder.

I still have a great deal of correction work to do on this file; the answers I have given you are hopefully clear enough.

ghost commented 1 month ago

This is the list of file names:

[MAME] Sample Name Filter List.zip

I would be REALLY surprised if you find a sample file that is NOT in this list but IS existing in MAME XML!

AntoPISA commented 1 month ago

Regarding the Samples you are partly right: there are in fact many files with different content but same name, thus explaining the difference between our two counts.

ghost commented 1 month ago

Regarding the Samples you are partly right: there are in fact many files with different content but same name, thus explaining the difference between our two counts.

yes and since there is nothing in the XML that tells what the actual content of the file is, my program can't know this. I didn't know same file names could mean different content. A mystery why they make it even more complex then it already is.

But i'm right about the other 2 issues :)

AntoPISA commented 1 month ago

But i'm right about the other 2 issues

I think I've already written to you that those two issues will be investigated further in the coming months, thank you very much.

AntoPISA commented 1 month ago

A mystery why they make it even more complex then it already is.

I completely agree with you.