search

AntonGepting / tmux-interface-rs

Rust language library for communication with TMUX via CLI
MIT License
51 stars 5 forks source link

Retain binary arguments for new session command #13

Closed MTBorg closed 2 years ago

MTBorg commented 2 years ago

When creating a NewSession-command from a TmuxCommand the binary arguments were not retained, causing snippets like 

TmuxCommand::new().file("abc").new_session();

to skip the -f option, making specifying a custom configuration file impossible. This should fix it.

AntonGepting commented 2 years ago

Hi, thank you for your information about this bug, and fixing PR!

In future version (current dev branch) there will be rework of these objects in general, Tmux as parent instance in default tmux mode for all commands like NewSession etc, that must solve such problems in future, and give the opportunity to run multiple commands in one underlying call of std::process::Command::exec()/output(). Before that, I think I'll make minor version with PR's and fixes from the community.

I'll add you in README.md in section contributing if you don't mind.

MTBorg commented 2 years ago

Happy to contribute :) No i don't mind 👍