ApeWorX / ape-etherscan

Etherscan explorer plugin using EVM-based networks for the Ape Framework
https://www.apeworx.io/
Apache License 2.0
22 stars 25 forks source link

feat: add support for Etherscan's rate limit [APE-774] #77

Closed fubuloubu closed 1 year ago

fubuloubu commented 1 year ago

What I did

Added a rate limit on the etherscan client that's config-driven, replicated some of the logic inside of estimate_query for more accurately depicting the rate limit

fixes: #76

How I did it

How to verify it

Checklist

linear[bot] commented 1 year ago
APE-774 "feat: add support for Etherscan's rate limit" (ApeWorX/ape-etherscan #77)

### What I did fixes: # ### How I did it ### How to verify it ### Checklist * [ ] Passes all linting checks (pre-commit and CI jobs) * [ ] New test cases have been added and are passing * [ ] Documentation has been updated * [ ] PR title follows [Conventional Commit](https://www.conventionalcommits.org/en/v1.0.0/) standard (will be automatically included in the changelog) --- [ApeWorX/ape-etherscan #77](https://github.com/ApeWorX/ape-etherscan/pull/77) by [fubuloubu](https://github.com/fubuloubu) on GitHub *via LinearSync*

github-actions[bot] commented 1 year ago

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.

theref commented 1 year ago

What is the status of this? I've been running into some rate limit issues

fubuloubu commented 1 year ago

What is the status of this? I've been running into some rate limit issues

Haven't had a chance to fix it up and incorporate @antazoey's feedback. If you copy my work into a new PR with those comments addressed, we can review and merge it

antazoey commented 1 year ago

does anything differ from what was done here: https://github.com/ApeWorX/ape-etherscan/pull/86 ? if yes, let's rebase. if no, let's close.

theref commented 1 year ago

does anything differ from what was done here: #86 ? if yes, let's rebase. if no, let's close.

No, you can close 🚀