Closed fubuloubu closed 1 year ago
### What I did fixes: # ### How I did it ### How to verify it ### Checklist * [ ] Passes all linting checks (pre-commit and CI jobs) * [ ] New test cases have been added and are passing * [ ] Documentation has been updated * [ ] PR title follows [Conventional Commit](https://www.conventionalcommits.org/en/v1.0.0/) standard (will be automatically included in the changelog) --- [ApeWorX/ape-etherscan #77](https://github.com/ApeWorX/ape-etherscan/pull/77) by [fubuloubu](https://github.com/fubuloubu) on GitHub *via LinearSync*
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.
What is the status of this? I've been running into some rate limit issues
What is the status of this? I've been running into some rate limit issues
Haven't had a chance to fix it up and incorporate @antazoey's feedback. If you copy my work into a new PR with those comments addressed, we can review and merge it
does anything differ from what was done here: https://github.com/ApeWorX/ape-etherscan/pull/86 ? if yes, let's rebase. if no, let's close.
does anything differ from what was done here: #86 ? if yes, let's rebase. if no, let's close.
No, you can close 🚀
What I did
Added a rate limit on the etherscan client that's config-driven, replicated some of the logic inside of
estimate_query
for more accurately depicting the rate limitfixes: #76
How I did it
How to verify it
Checklist