ApeWorX / ape-ledger

Ledger Nano S and X account plugin for the Ape Framework
https://www.apeworx.io/
Apache License 2.0
6 stars 7 forks source link

fix: page offset error [APE-989] #37

Closed fubuloubu closed 1 year ago

fubuloubu commented 1 year ago

What I did

Noticed that there was a paging offset error for selecting addresses past the first page

fixes: #36

How I did it

educated guess

How to verify it

have to actually try it

Checklist

linear[bot] commented 1 year ago
APE-989 "fix: page offset error" (ApeWorX/ape-ledger #37)

### What I did Noticed that there was a paging offset error for selecting addresses past the first page fixes: #36 ### How I did it educated guess ### How to verify it have to actually try it ### Checklist * [ ] Passes all linting checks (pre-commit and CI jobs) * [ ] New test cases have been added and are passing * [ ] Documentation has been updated * [ ] PR title follows [Conventional Commit](https://www.conventionalcommits.org/en/v1.0.0/) standard (will be automatically included in the changelog) --- [ApeWorX/ape-ledger #37](https://github.com/ApeWorX/ape-ledger/pull/37) by [fubuloubu](https://github.com/fubuloubu) on GitHub *via LinearSync*

fubuloubu commented 1 year ago

validated it solved the user's issue in #36