ApeWorX / eip712

Message classes for typed structured data hashing and signing in Ethereum
Apache License 2.0
42 stars 19 forks source link

Add .encode() #51

Open poolpitako opened 5 months ago

poolpitako commented 5 months ago

Overview

Provide a simple overview of what you wish to see added. Please include:

linear[bot] commented 5 months ago

APE-1734 Add .encode()

fubuloubu commented 5 months ago

thinking further, since this class is a dataclass it's usually not wise to add another method to it, but we can just make a pure function abi_encode_struct that does the same thing

poolpitako commented 5 months ago

thinking further, since this class is a dataclass it's usually not wise to add another method to it, but we can just make a pure function abi_encode_struct that does the same thing

why that logic doesn't apply to signable_message()?

fubuloubu commented 5 months ago

thinking further, since this class is a dataclass it's usually not wise to add another method to it, but we can just make a pure function abi_encode_struct that does the same thing

why that logic doesn't apply to signable_message()?

it probably should lol, but would be more annoying