search

Apicurio / apicurio-registry

An API/Schema registry - stores APIs and Schemas.
https://www.apicur.io/registry/
Apache License 2.0
584 stars 259 forks source link

Compatibility Rule: XSD #4995

Open adabuleanu opened 1 month ago

adabuleanu commented 1 month ago

Feature or Problem Description

Add schema compatibility rules for XSD.

Proposed Solution

A solution similar with the JSON compatibility rules or protobuf compatibility rules.

Additional Context

Currently the compatibility feature is implement only for avro, json and protobug. Historically there were a couple of tickets opened for adding compatibility rules for different artifacts: https://github.com/Apicurio/apicurio-registry/issues/15 https://github.com/Apicurio/apicurio-registry/issues/16 https://github.com/Apicurio/apicurio-registry/issues/217 https://github.com/Apicurio/apicurio-registry/issues/218 .

Is there a reason for not having a dedicated ticket for XML or XSD artifact?

As per the proposed solution, we can contribute a best-effort implementation for XSD compatibility checks. Is this something you would be willing to accept a PR for?

apicurio-bot[bot] commented 1 month ago

Thank you for reporting an issue!

Pinging @jsenko to respond or triage.

simonnepomuk commented 2 days ago

Hey @adabuleanu,

my PR for OpenAPI compatibility checks was just merged, so I believe they would be open to best-effort implementations. @EricWittmann is that correct?

EricWittmann commented 13 hours ago

Absolutely!