AppLovin / AppLovin-MAX-Unity-Plugin

121 stars 33 forks source link

Google Ad Manager and Admob breaks Upgrade All functionality #262

Open kocburak opened 1 year ago

kocburak commented 1 year ago

MAX Plugin Version

5.10.1

Unity Version

2021.3.20

Device/Platform Info

Editor

Current Behavior

If Google Ad Manager and Admob has new versions, Clicking to "Upgrade All" button results with the error below and editor needs to be restarted. If every Upgrade is done manually error does not occur. This happened to me each time there is an google network update.

245196951-8ba5093e-1e6b-458a-9bcf-686eace29e32

Expected Behavior

Upgrade All button must upgrade all available networks without error.

How to Reproduce

Set Google Ad Manager and Admob network sdks for older versions. Open editor. Click "Upgrade All" button

Additional Info

No response

JonathanLiuApp commented 1 year ago

Thank you for bringing this to our attention. Unfortunately, I was unable to reproduce the error. Were you able to reproduce this in our demo app?

kocburak commented 1 year ago

Yes I am able to reproduce this issue on demo app. I made a commit to reproduce this issue in this repo. I opened the project while Android platform on 2021.3.20 is selected if that matters. As you can see from the latest commit I added multiple mediation network that needs to be updated.

Note: I waited to EDM to resolve and download all libraries

JonathanLiuApp commented 1 year ago

@kocburak I cloned the example repository you provided, ensuring that all settings were replicated exactly as you had them. However, I was still unable to reproduce the issue you encountered. To assist me further in understanding the problem, could you please provide any console logs you saw when the error occurred?

kocburak commented 1 year ago

Editor.log Unfortuntely when this window is displayed, whole editor is stop reponding. So I can't see any logs. But here is the editor log data. My system is Windows 10 btw. If you need any information about editor settings or any system related information I would be happy to help.

kocburak commented 1 year ago

If you need more info, I would be happy to asist.

JonathanLiuApp commented 1 year ago

I attempted to reproduce on both Apple and Windows devices, but was still unable to. Could you try force resolving Android with the External Dependency Manager and seeing if the error still occurs? If the error persists, could you provide the versions of the google adapters before you tried to upgrade them?

kocburak commented 1 year ago

I does not matter the google adapter version. I force resolved it and still I had it again. Current adapter version on our game is "android 22.1.0.4_ios_10.6.0.1" for admob and "android 22.1.0.3_ios_10.6.0.1" for Google Ad Manager. Clicked Upgrade All. Then the error showed up again. When I reopened the Editor it updated to "android 22.1.0.4_ios_10.7.0.0" and "android 22.1.0.4_ios_10.7.0.0" respectively. It says something like "AndroidManifest.xml.meta system path could't find". My guess is your Upgrade All functionality try to edit same file (AndroidManifest.xml) for both Ad Manager and AdMob but since the edited version didn't reimported yet, it cannot find.