search

Appboy / appboy-android-sdk

Public repo for the Braze Android SDK
https://www.braze.com
Other
152 stars 102 forks source link

[Bug]: DefaultInAppMessageViewWrapper is not inheritable anymore #235

Closed snappdevelopment closed 2 years ago

snappdevelopment commented 2 years ago

Braze Android SDK Version

23.1.0

Steps To Reproduce

In 23.1.0 the DefaultInAppMessageViewWrapper got converted from Java to Kotlin which can be seen here.

In Java this class can be inherited from to implement a custom version of it. This is not possible anymore since Kotlin classes are final by default.

Expected Behavior

DefaultInAppMessageViewWrapper should be inheritable. This could be fixed by adding the open keyword to the class.

Actual Incorrect Behavior

DefaultInAppMessageViewWrapper is final and can't be inherited.

Verbose Logs

No response

Additional Information

No response

radixdev commented 2 years ago

Hi @snappdevelopment ,

We will have a fix available soon and will update this issue with any updates. Thank you for filing!

radixdev commented 2 years ago

Hi @snappdevelopment ,

This is fixed in 23.1.1 of the SDK.