search

AprilSylph / XKit-Rewritten

🧰 The enhancement suite for Tumblr's new web interface
GNU General Public License v3.0
295 stars 48 forks source link

Tweaks: "Make following/mutuals indicators on notifications more subtle" option is broken #1649

Open AprilSylph opened 2 weeks ago

AprilSylph commented 2 weeks ago

Platform

Steam Deck

Browser

Firefox 132.0.1 (64-bit)

Addon version

v1.0.4

Details

Activity items are using a new label component that the "Make following/mutuals indicators on notifications more subtle" tweak does not affect, seemingly in any capacity.

marcustyphoon commented 2 weeks ago

Me: "Oh no, they look the same, how could my code have broken?" The element: *has no icon, rendering the concept of the tweak pointless* Me: "Oh."

I guess we can add an icon, then collapse to it.

Related: the communities members page has the same element; implementing this for activity notifications would allow it to be implemented there as well.

AprilSylph commented 2 weeks ago

@marcustyphoon your actions recently (review requests, assignments) have been undone in the same minute, is GH Desktop acting up or are you just in a spell of going back on decisions today?

marcustyphoon commented 2 weeks ago

The latter :D I realized that I don't know which of my PRs merge conflict without checking further, and on reflection it's not obvious to me what to do with this one.