search

ApryseSDK / webviewer-ui

WebViewer UI built in React
Other
416 stars 354 forks source link

[Bug] Toolbar does not show up if 'header' is disabled #1036

Open vekunz opened 1 year ago

vekunz commented 1 year ago

WebViewer version

10.5.1 (after updated from 10.2.3)

The current behavior

When disabling the header element, the toolbar does not show up, if set manually.

The expected behavior

When set manually, the toolbar should show up even if the header is disabled (like before).

Steps to reproduce

  1. Disable 'header' element: instance.UI.disableElements(['header']);
  2. Set any toolbar group: instance.UI.setToolbarGroup('toolbarGroup-Annotate');

In the DOM, the toolbarGroup is added, but on the toolsHeader element in the DOM, the closed class is not removed.

bollain commented 12 months ago

Hi @vekunz,

Thanks for this report. I've verified there is a regression here. This has been added to our backlog - when it gets addressed we will let you know which version will have the fix via this report.

Thanks

vekunz commented 8 months ago

Is there any forecast for when the error will be fixed?

bollain commented 7 months ago

Hey @vekunz,

This issue is still in the backlog, I will reach out to our PMs to schedule it. In the meantime you can try our new Modular UI which should allow you to do these types of customizations and more. Docs here.