search

ApryseSDK / webviewer-ui

WebViewer UI built in React
Other
416 stars 353 forks source link

Network error dialog does not dismiss #160

Closed glendaviesnzdiligent closed 5 years ago

glendaviesnzdiligent commented 5 years ago

In v1.1.0 the network error dialog does not dismiss, either with subsequent page load request, or clicking outside the dialog, a page refresh is needed to get rid of it.

If you get the network error dialog it is possible to load another document into the viewer, and this loads successfully and can be seen behind the error overly. Ideally a successful new document load should dismiss the error dialog.

Thanks

ZhijieZhang commented 5 years ago

Hi there,

Unfortunately we were not able to reproduce the issue you are seeing. Here are the steps we took:

  1. Checkout master branch and run npm start

  2. Open developer tools and in the console, run 

    readerControl.loadDocument('http://www.derpreport.com/wp-content/uploads/2017/02/GAA_Book.pdf')

  3. Error dialog pops up showing: Network failure

  4. In the console, load another document:

    readerControl.loadDocument('https://pdftron.s3.amazonaws.com/downloads/pl/webviewer-demo-annotated.pdf')

  5. The above document loads successfully and the error dialog disappeared

We think this issue should be fixed in commit https://github.com/PDFTron/webviewer-ui/commit/b30a17ee626a2502c58fcd0e2db7c0cb1888bf0e. If you try the steps above, are you still able to reproduce this issue? If yes, can you try pulling from the latest master branch to see if the issue remains?

Thanks

justinjung04 commented 5 years ago

We will close this issue due to inactivity. Feel free to reopen it if needed!