Closed RuinedYourLife closed 2 years ago
NeonixRIT
commented
2 years ago Will test this later. Thanks for the changes (glancing over the code it looks fine). Would prefer the individual changes to be separate pull requests, I’ll have to make pull sort of template for that. Yes the code is messy atm, that’s what the refactor branch is for. We’re also testing out a different GUI framework with unity.
RuinedYourLife
commented
2 years ago will do sorry for the messy PR.
you got me interested at new GUI framework! i was looking into writing my own hack in c++ and do a directx renderer for ESP and menu, i have the renderer on it's own, but i'm not that good yet to put it in the game.
thanks for the feedback!
NeonixRIT
commented
2 years ago Sorry for taking so long. Been working on v3.0.0.
Snow has tested a build with your code and we have reviewed it.
The changes made to the look of the ESP are great. However there are a few things to address.
This PR will remain open until you have committed the above changes or just before v3.0 is released.
NeonixRIT
commented
2 years ago Image for new look reference (it's really nice)
AquaticLabs
commented
2 years ago really dirty code that can be changed A LOT just to make the esp more pleasant to look at. just wanted to showcase a simple way to do it.
- separated each type of interactables so we can eventually create new buttons in the menu to only turn on specific ones.
- slapped a different renderer in there which i'm more used to work with (centered coordinates, yours got me triggered lol).
- each interactable category is now colored differently with different units too.
i removed on my master branch some stuff that mentionned umbra where i just wanted to have the useful infos, in the future i will create an other branch to keep that separated. for now i guess you can inspire yourself from that or just "cherry pick" the code you want (not actual git cherry pick cause only one commit). maybe put the csproj file in the gitignore too?
was currently looking at more esp changes + optimisation (cache variables like the camera, coroutines for less calls...) so lemme know if that could be useful
Noticed you ripped off all the branding and any hint to our discords or this github page?, for a PR that's something I'd leave on. for your own private version do what you please haha.
Also saw you replaced the For loops to be Foreach loops, when it comes to performance, ‘foreach’ takes much more time as compared to the ‘for’ loop because internally, it uses extra memory space, as well as, it uses GetEnumarator() and Next() methods of IEnumerables.
I personally really liked the colors you implemented as they are much less intrusive on the gameplay, well done there!
RuinedYourLife
commented
2 years ago thank you the both of you for the review
i'm sorry for the removal of the branding, i forgot to add it back in while doing the PR, i removed it cause i like it cleaner... i will add it as soon as i get to work on it again!
i will fix the for loops too on the same commit
looking forward to hearing from you guys again on v3!!
RuinedYourLife
commented
2 years ago branding should be fixed now! from now on i'll make new branches if i ever work on some new stuff
NeonixRIT
commented
2 years ago looking forward to hearing from you guys again on v3!!
v3's main progress is currently public on the v3 branch and I have a progress list in the discord server
really dirty code that can be changed A LOT just to make the esp more pleasant to look at. just wanted to showcase a simple way to do it.
i removed on my master branch some stuff that mentionned umbra where i just wanted to have the useful infos, in the future i will create an other branch to keep that separated. for now i guess you can inspire yourself from that or just "cherry pick" the code you want (not actual git cherry pick cause only one commit). maybe put the csproj file in the gitignore too?
was currently looking at more esp changes + optimisation (cache variables like the camera, coroutines for less calls...) so lemme know if that could be useful