Data binding over list attributes

ArcBees / gwtquery

A jQuery clone for GWT, and much more.

MIT License

85 stars 38 forks source link

Data binding over list attributes #356

Closed apanizo closed 9 years ago

apanizo commented 9 years ago

When doing data binding over a list attribute, return an empty list or null if the received JSON is an empty array or null accordingly.

review-ninja commented 9 years ago

jDramaix commented 9 years ago

LGTM

jDramaix commented 9 years ago

Thanks and sorry for the delay

manolo commented 9 years ago

@apanizo although the patch is ok and tests by default pass, there is something wrong in the JS implementation since tests do not pass in production mode (compiled)

 mvn clean package -> passes
 mvn clean package -Dtest-prod  -> fails : 

 Failed tests: 
  test_return_null_when_list_is_not_specified(com.google.gwt.query.client.dbinding.DataBindingTestGwt):      expected: null, actual: <[]>