ArduPilot / ArduRemoteID

RemoteID support using OpenDroneID
GNU General Public License v2.0
90 stars 45 forks source link

include multiple encoding errors in OPEN_DRONE_ID_ARM_STATUS message #102

Closed BluemarkInnovations closed 10 months ago

BluemarkInnovations commented 1 year ago

In the current implementation, the check_parse fails on the first error whenit encounters bad data in one of the RID packets.

In this PR, the function will collect all bad data errors and include the packets that fail in in the ARM status error field. This is useful in case the data stream has multiple errors. For instance if the system message has an error and the operator ID too, the current implementation would only return that the system message fails.

BluemarkInnovations commented 1 year ago

Implemented a new PR with the requested changes.

tridge commented 1 year ago

needs a rebase, sorry

BluemarkInnovations commented 1 year ago

did a rebase and squashed the commits.

BluemarkInnovations commented 1 year ago

Seems to be ready for merge, see comment April 3.

tridge commented 10 months ago

@BluemarkInnovations i've cleaned up the string handling a bit