search

ArduPilot / ardupilot

ArduPlane, ArduCopter, ArduRover, ArduSub source
http://ardupilot.org/
GNU General Public License v3.0
10.81k stars 17.26k forks source link

Copter: implement Circle within Guided (aka LOITER_TURNS) #13464

Open rmackay9 opened 4 years ago

rmackay9 commented 4 years ago

This enhancement request comes from this discussion: https://discuss.ardupilot.org/t/copter-not-supporting-mav-cmd-nav-loiter-turns-question/51785

The request is to implement Circle mode (aka LOITER_TURNS) from within Guided mode.

Support for LOITER_TURNS is already implemented in Auto mode so this should be possible.

arshPratap commented 3 years ago

I have a PR(#16473) that works on the issue. Would be nice, I could get some suggestions on it . Thanks in advance!!

shiv-tyagi commented 2 years ago

I think I can work on this since I see no activity here for almost a year. Thanks @arshPratap for all you work :-)

arshPratap commented 2 years ago

Thats great to hear ! I am sorry I wasnt able to work on some of my PRs as I am currently busy with some other commitments. @shiv-tyagi A helpful advice would be to look and understand some of the issues that were present in my PR (specially the part where the CIRLE code was reused from a prior segment and the suggestion was to generalize that part of code) Looking forward to your PR! Thanks

shiv-tyagi commented 2 years ago

@arshPratap Thanks! I saw the issues with your PR and tried to address them in my PR #19718. Please have a look.

shiv-tyagi commented 2 years ago

@rmackay9 Can you please review my PR? Thanks in advance.

adityaomar3 commented 1 year ago

@shiv-tyagi @peterbarker @rmackay9 @arshPratap is this issue still unresolved ? I would like to work on it

shiv-tyagi commented 1 year ago

@adityaomar3 I think this is still open. I actually submitted #19718 was intended to close this but I couldn't get it in. Feel free to refer to that branch. All the best.