ArgoCanada / argoFloats

Tools for analyzing collections of oceanographic Argo floats
https://argocanada.github.io/argoFloats/index.html
17 stars 7 forks source link

Add subset by polygon to mapApp() #568

Closed j-harbin closed 2 years ago

j-harbin commented 2 years ago

Two known "bugs":

  1. If in polygon mode, and user tries to zoom, the app will not zoom in (which is what we want) but it does cause an additional polygon point from the click that was required for the attempted zoom. This additional point can removed by simply clicking "u"
  2. If the user subset by polygon and clicked "q" to indicate they are done, the app is NO LONGER is polygon mode. This means that the user IS ALLOWED to zoom with a brush. The zoom works correct, however, if the user clicks "u" to undo the zoom there will be an extra point in their Gray polygon. This again can be removed using "u".

I have tried many different ways to fix these, but I can't figure it out. They are not major issues as the user simply needs to click "u", however, it's worth noting.

codecov[bot] commented 2 years ago

Codecov Report

Merging #568 (e0eb70e) into develop (51f00c4) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #568   +/-   ##
========================================
  Coverage    56.62%   56.62%           
========================================
  Files           15       15           
  Lines         2024     2024           
========================================
  Hits          1146     1146           
  Misses         878      878           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 51f00c4...e0eb70e. Read the comment docs.

dankelley commented 2 years ago

Ta.