search

ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
53 stars 51 forks source link

Feature/add unit tests #131

Closed ArieGato closed 6 months ago

ArieGato commented 6 months ago

Add Unit tests for RabbitMQ classes

codecov-commenter commented 6 months ago

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

sungam3r commented 6 months ago

@ArieGato Good changes. I just looked through briefly. IRabbitMQChannel, IRabbitMQClient, IRabbitMQConnectionFactory look like not a part of public API. You use these interfaces for test purposes. Let's make them internal.

ArieGato commented 6 months ago

Thnx for taking the time to check the PR. Really appreciate it.

Initially I created the interfaces internal, but then I had to add Internals Visisble to one of the mocking framework assemblies. I was reluctant to do that. I'll try to come up wth a good solution.