Closed Acid-Crash closed 4 years ago
I'm wondering with part of the code causes the width change for you. Any idea?
I also removed the line above the results, because it seemed wrong there.
:-moz-any(.searchbar-textbox, #urlbar,#searchbar) {
font-size: 12px !important;
}
#urlbar-container[breakout] {
position: relative !important;
min-height: var(--urlbar-container-height);
}
#urlbar[breakout]:not([open]) {
position: relative !important;
display: inherit !important;
height: var(--urlbar-height) !important;
}
#urlbar[breakout][breakout-extend]:not([open]) {
top: unset !important;
left: unset !important;
width: 100% !important;
}
#urlbar[breakout][breakout-extend][open] {
top: calc((var(--urlbar-toolbar-height) - var(--urlbar-height))/2) !important;
left: 0px !important;
width: 100% !important;
}
#urlbar[breakout][breakout-extend] > #urlbar-background {
box-shadow: unset !important;
}
#urlbar[breakout] > #urlbar-input-container {
height: var(--urlbar-height) !important;
}
#urlbar[breakout][breakout-extend] > #urlbar-input-container {
height: var(--urlbar-height) !important;
padding-block: unset !important;
padding-inline: unset !important;
}
#urlbar[breakout][breakout-extend] > #urlbar-background {
animation-name: unset !important;
}
.urlbarView.megabar .urlbarView-body-inner {
border-top: unset !important;
}
.megabar #urlbarView-results {
padding: 0px !important;
}
.megabar #urlbar-results .urlbarView-body-outer,
.megabar #urlbar-results .urlbarView-row,
.megabar #urlbar-results .urlbarView-row-inner {
-moz-margin-start: 0 !important;
-moz-padding-start: 0 !important;
-moz-margin-end: 0 !important;
-moz-padding-end: 0 !important;
}
.megabar #urlbar-results .urlbarView-row-inner {
-moz-padding-start: 4px !important;
-moz-padding-end: 4px !important;
}
No clue. Tried to disable every module apart from _megabaroptimizations.css and the issue remains. So it is definitly within this module... Seems like it somewhat related to the number of icons that are placed at the end of the URL bar (action icons the call them?). The more Icons I place there the bigger offset becomes...
At the same time this behavior seems really strange. I would expect that at some point of animation (or state) the with is redefined...
Can you list the add-ons adding action buttons to your location bar?
Edit
I've added all default buttons, that are available and even enabled buttons_on_navbar_squared_buttons_fx72.css
, but nothing changed. The bar does not jump or change position here. I have to run some more tests once I'm at home.
Resolution 1920*1080
Extensions: URL bar https://addons.mozilla.org/en-US/firefox/addon/crxviewer/
NavBar https://addons.mozilla.org/en-US/firefox/addon/undo-closed-tabs-revived/ https://addons.mozilla.org/en-US/firefox/addon/styl-us/ https://addons.mozilla.org/en-US/firefox/addon/cookie-autodelete/ https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/
Update. I've tried to create a new profile and found some additional results. Disabled everything apart from classic appearance and megabar (config attached) Indeed, there is some sort of relationship between this bug and the icons in the URL Page actions section.
Default new tab page (no items in the Page actions section, only dropDown icon) Result - the jumping is gone.
Page: google.com (dropDown icon, Page actions, Pocket, boomark this) Result- jumping is there
Config:
Nothing I try causes this issue for me. Location bar does not move, not even a pixel.
Tested with a few action buttons (default one and from add-ons). compact, normal and touch modes, hidpi settings... etc.
top - megabar_optimizations.css disabled - location bar focused
middle - megabar_optimizations.css disabled - location bar not focused
bottom - megabar_optimizations.css enabled - location bar focused
Hmm, strange I still experience this issue on two different PCs. Just to double check, the jumpings happen if the History/dropDown arrow is pressed or if I start typing URL and suggestions appear. The regular Focus on a addresbar is fine.
Here, maybe this will help.
A quick demo: clean profile, default CSS v2.9.1 config
UPD. Now I'm confused, maybe it somewhat related to resizing searchbar-URL bar...
I see the issue in your video, but I have no idea why it occurs and why I can not replicate it. Tried the same steps your did.
The location bar has indeed a flex value that might somehow intervene.
Ok, good news here. It looks like I've noticed the pattern of this behavior. Once again everything done on a clean profile When searchbar is placed for the firs time next to URL bar, the browser lets you to distribute the proportions(width) of each element. If I don't do anything (aka default proportions) the bug appears. If I redistribute proportions (eve for a small amount) the bug vanishes.
The cheesy thing is that if I place some buttons between URL and Search the option to resize seem to be hidden.
All in all this smells like a FF bug to me... uncommon but still a bug, so guess we can take it out of this project list.
Have you had a chance to look at that suggestion regarding offset that I've mentioned it the initial comment?
If I don't do anything (aka default proportions) the bug appears. If I redistribute proportions (eve for a small amount) the bug vanishes.
Different screen resolutions might lead to different results too, since the width of some elements in Firefox is always calculated and depending on screen/window size values.
Have you had a chance to look at that suggestion regarding offset that I've mentioned it the initial comment?
I think I cheated that one away by removing the line entirely:
.urlbarView.megabar .urlbarView-body-inner {
border-top: unset !important;
}
The border roundness doesn't work any longer for the urlbar on Firefox 73 either using the megabar_optimizations.css or without it. The searchbar is fine. What can be modified in the locationbar_border_roundness.css to fix that?
Edit: For now I have set the browser.urlbar.update1 to false and now it is round.
@Acid-Crash Still no clue why this can not be reproduced in my tests. Tested on different computers running Win 10 with and without creating new browser profiles.
@glennpc The megabar roundness has to be set differently than before, updated code will be added on next update. However the code is only for the megabar, if it is not open. Otherwise the roundness affects the whole popup.
@Aris-t2 No problem, seems like a very specific issue. Nevertheless, seems like it is not directly related to this project code (or at least there is a solution to fix it), so this bug report can be closed...
OK, post here anyway, if you find something new about this case.
Describe the issue When interacting with URLBar (in Megabar aka update1 mode) there is a slim width change that leads to a "shuddering" of remaining elements
What should have happened instead? The width of megabar should remain the same.
Steps to reproduce the issue? Enable
./css/locationbar/megabar_optimizations.css
Make sure that browser.urlbar.update1 is set to trueWithout
megabar_optimizations.css
the position of other elements remains the sameAlso dropDown has is a small top offset (1px I believe). Not sure if this is intentional, but pushing it up 1px to 'dock' it to the Identity box section sound like a good idea. Also this will make it the same height as the default state URL bar