search

ArkeologeN / node-linkedin

LinkedIn 2.0 wrapper in Node.js
MIT License
163 stars 78 forks source link

Add a timeout parameter. #17

Closed bradvogel closed 10 years ago

bradvogel commented 10 years ago

Issue #16. Adds a timeout parameter to Linkedin.init().

ArkeologeN commented 10 years ago

Errm, it would be good practice if we make 1st argument as access_token and second argument as object (optional).

This object would check for timeout key for now and later on, if we need to set some more parameters then they would be passed through?

Sound something like:

Linkedin.init(my_access_token, {timeout: 10000, key: value, foo: bar});
bradvogel commented 10 years ago

No problem, filed https://github.com/ArkeologeN/node-linkedin/pull/19

ArkeologeN commented 10 years ago

Awesome @bradvogel ! Thanks! Just releasing it over!