search

ArminJo / Talkie

Refurbished Arduino version of the Talkie library from Peter Knight.
GNU General Public License v3.0
214 stars 52 forks source link

correct output filter capacitor prefix #24

Closed DebinixTeam closed 3 years ago

DebinixTeam commented 3 years ago

I corrected the DC-blocking capacitor prefix in the output filter.

ArminJo commented 3 years ago

Please read the theory of low pass filters (with load) before you make nonsense improvements!

DebinixTeam commented 3 years ago

Sorry if I insulted you personally in any way, not my intention at all. Your comment is quite rude. I did all work on my side, putting together a pull request to make it easy for you, not just filing an issue for you to fix. You have an inconsistency in the description. In your text in the last point paragraph about series capacitors, you say, "1 to 10 uF do block the DC, " but it's drawn a 10nF capacitors in the figure (which I corrected after your Hints-text. That was my only point, not to insult nor try to be a competent designer. I'm sorry if you misunderstood my intentions. Regards.

ArminJo commented 3 years ago

Ok, sorry for being rude, but if you check the differences/files changed , you will see that you corrupted the micro signs, which is not good for a pull request anyway. And the 10uF are for a speaker, and not for an amplifier input. Please better next time think twice, before doing such well meant effort. And then do a QS!