search

Arnuh / EchoPet

Adds pets to your Minecraft Server!
GNU General Public License v3.0
25 stars 12 forks source link

specialsource-maven-plugin also renames echopet methods if methods collide #116

Closed Arnuh closed 2 years ago

Arnuh commented 2 years ago

Example is EntityAgeablePet#setBaby(boolean) which overrides a method in Mob resulting in it getting renamed to obf name and baby petdata toggling failing

Only solutions I can think of are to rename such methods or request/add a way to filter methods to https://github.com/md-5/SpecialSource/

Arnuh commented 2 years ago

As mentioned in https://github.com/Arnuh/EchoPet/commit/d16973636f14f73db54dba82523dc0d2fc99d096, with #106 slowly making pets the 'real' entity we will be moving away from "IEntityXXPet" and instead handling any setting of variables for a pet via "EntityXXPetBase". This will allow the PetBase class to properly get its method calls remapped to the obfuscated naming without renaming our setters.