search

ArpNetworking / sbt-typescript

A plugin for SBT that uses sbt-web to compile typescript resources.
Apache License 2.0
60 stars 26 forks source link

The options lack new modules format support #18

Closed mickeyvip closed 8 years ago

mickeyvip commented 9 years ago

Although the new version uses 1.6.2 compiler - it lacks new features.

One of them is more module formats:

https://github.com/Microsoft/TypeScript/blob/master/src/compiler/types.ts#L2073

export const enum ModuleKind {
    None = 0,
    CommonJS = 1,
    AMD = 2,
    UMD = 3,
    System = 4,
}

Also, it seems from their example that you don't need to use numeric constants, there is an Enum for modules:

import * as ts from "typescript";
/// ...
let commonJsModule = ts.ModuleKind.CommonJS;
let systemModule = ts.ModuleKind.System;

Thank you.

laguiz commented 9 years ago

This issue may help : https://github.com/ArpNetworking/sbt-typescript/issues/23

mickeyvip commented 8 years ago

My PR that adds new modules was merged.