Open miketrethewey opened 5 years ago
Do we need to have NES and SNES games be subfolders of different folders? For instance, can we just have folders for zelda1, zelda2, and zelda3, without separating them further?
There are several instances where there are several games with the same name but on different consoles. “Sonic the Hedgehog [1]” for instance is called the same whether it's on the Sega Master System, Sega Game Gear or Sega Genesis/MegaDrive. Tetris is similar.
At this point we only have 2 games implemented, so whether or not the duplicate names thing will come to a head depends heavily on the size of our ambition for this project.
[ ]
gamelib.py
autodetect()
: Hard check for SMC/SFC. Also has hard checks for Z3Link & M3Samuspng
sizes.get_game_type_from_zspr_data()
: Assumes allzspr
s are Z3Link.get_game_type_from_rdc_data()
: Assumes allrdc
s are M3Samus.get_game_class_of_type()
: Assumes all games are in the same folder. Ideally, we'd move Z3 & M3 to a SNES folder.GameParent()
: Assumes all games are SNES games by default. Can be overridden.make_sprite_by_number()
: Assumes all games are in the same folder.get_rom_from_filename()
: Assumes all games are in the same folder.[x]
gui.py
open_file()
: Assumes all games are SNES games.copy_into_ROM()
: Assumes all games are SNES games.copy_into_ROM_bulk()
: Assumes all games are SNES games.[x]
spritelib.py
import_from_filename()
: Assumes all games are SNES games. Assumes all games are in the same folder.