search

Artur- / spring-data-provider

Spring Data Provider for Vaadin 8 and 10
Apache License 2.0
15 stars 14 forks source link

Pageable and sort order problem #11

Open dmarko484 opened 6 years ago

dmarko484 commented 6 years ago

Hello, I'm trying to use your provider with Vaadin 10(beta10) and I struggle with sort order not working properly. I have 'FilterablePageableDataProvider' attached to 'com.vaadin.flow.component.grid.Grid' . I have a few columns defined as sortable in the Grid. Now when I click on any sortable column, I cannot see a proper sorted column name in 'fetchFromBackEnd' method in Pageable object (using code below). 

 protected Page<Porada> fetchFromBackEnd(Query<Porada, String> query, Pageable pageable) {          
    System.out.println(pageable.getSort().iterator().next().getProperty());
    ...
}

What I always get is column name defined in getDefaultSortOrders() ... in provider. Any ideas what is going one here?

BTW: Thanks for such a great addon!

TatuLund commented 2 years ago

See also: github.com/vaadin/framework/issues/12411

SebastianDietrich commented 1 year ago

We had the same issue until we found out the obvious: Pagination needs unique entries - i.e. if you sort a grid based on a row that is not unique, then pagination will possibly return the same elements twice or others not even once. --> make sure that you sort based on a row AND some unique row (e.g. ID)