search

Artur-Sulej / excellent_migrations

An Elixir tool for checking safety of database migrations.
MIT License
232 stars 25 forks source link

Fix transposed index errors #24

Closed bismark closed 1 year ago

bismark commented 1 year ago

I believe these errors are incorrectly transposed, e.g. if ddl_transaction_disabled?=false, then the error should be :index_concurrently_without_disable_ddl_transaction not :index_concurrently_without_disable_migration_lock.

bismark commented 1 year ago

Hi @Artur-Sulej, checking in on the status here, we'd like to get off our fork with this fix.

Artur-Sulej commented 1 year ago

@bismark Thanks a lot for the PR and a bump. Great catch!

JoeyBG commented 8 months ago

@Artur-Sulej, could you release a new version with this change? Thanks

Artur-Sulej commented 8 months ago

@JoeyBG Done ✅ Cheers!