Open epinault opened 1 year ago
Not sure if I'm encountering the same exact issue as @epinault , but shouldn't this alone pass the excellent migrations checks?
defmodule MyMigration do
use Ecto.Migration
def change do
create table(:mytable) do
add(:some_field, :uuid, null: false)
timestamps()
end
create(unique_index(:mytable, [:some_field]))
end
Why do I need to concurrently create an index on a newly created table? The table is new, and therefore doesn't contain any data, so creating the index should be fast.
based on recent change in Ecto SQL 3.9.x , it seems that it s not working correctly anymore this check. They added an advisory pg lock. per https://hexdocs.pm/ecto_sql/Ecto.Migration.html#index/3-adding-dropping-indexes-concurrently
I tried creating a migration that has a config of advisory lock but the check complained incorrectly until I added the following
@disable_migration_lock true
to my migration. This is wrong because the point of the advisory lock is to avoid removing all completely the lock?
I would be happy to help but not sure how this works