search

Artur-Sulej / excellent_migrations

An Elixir tool for checking safety of database migrations.
MIT License
232 stars 25 forks source link

Credo checks integration broken in 0.1.7 #39

Closed axelson closed 3 months ago

axelson commented 3 months ago

When I upgrade from 0.1.6 to 0.1.7 I no longer get excellent_migrations errors via Credo (I'm testing with Credo 1.7.7 but it appears to apply to most any version).

The culprit appears to be https://github.com/Artur-Sulej/excellent_migrations/pull/24

The PR itself looks fine to my eyes so I wonder if there is another part of excellent_migrations that was inadvertently depending on the swap.

I also tested with 0.1.7 but undoing the swap and when I do that I do get excellent_migrations error reported by mix credo.

axelson commented 3 months ago

Ah, nevermind. I wasn't running my credo check properly (I was running mix credo priv/repo/migrations which doesn't match any files, instead I needed to run mix credo priv/repo/migrations/*). And I was also misinterpreting the errors (which were in fact swapped on 0.1.6)