search

Ashar25 / RainyDay

0 stars 1 forks source link

Inconsistent typing of 'latrange' and 'lonrange' #15

Closed danielbwright closed 1 year ago

danielbwright commented 1 year ago

The following issue was detected while revising diagnostic plotting capabilities. To reproduce this, your json file likely needs "DIAGNOSTICPLOTS" : "true"

If "CREATECATALOG" : "true", latrange and lonrange are numpy arrays, whereas if "CREATECATALOG" : "false", then they are xarray data arrays. This needs to be made consistent, preferably making them xarray data arrays in both cases.

Ashar25 commented 1 year ago

This can be fixed the only problem with xarrays here is np.where is the primary function which is not working properly with xarray. I think we can make them as xarray dataarray everywhere and then use it as a NumPy array wherever required.

danielbwright commented 1 year ago

THis is a high priority.

Ashar25 commented 1 year ago

Done until the diagnostic plot but I believe it can work for FA too.