Ashar25 / RainyDay

0 stars 1 forks source link

unnecessary dimensions in storm catalog files? #19

Closed danielbwright closed 10 months ago

danielbwright commented 11 months ago

Do we really need all these: netcdf file:/Users/daniel/Google_Drive/RainyDay2/Summer2023_RefactorTesting/Madison_ExampleCatalog_nclimgrid84.nc { dimensions: catmax = 100; xloc = 100; yloc = 100; stormtime = 100; duration = 3; time = 3; longitude = 60; latitude = 36;

It seems like we could have just 4 dimensions: 'latitude', 'longitude', 'time' and something like 'nstorms'

Ashar25 commented 11 months ago

I don't think this is unnecessary. The issue was we had added the storm variables like cat time, catmax, catx, caty as arrays to each of the storm netcdfs. The variables cannot be added without having a dimension in xarray (as far as I have understood and tried).

Ashar25 commented 11 months ago

We can have a single dimension for catmax, xloc, yloc, and time.

danielbwright commented 11 months ago

this is a high priority.

Ashar25 commented 11 months ago

Done.