Ashar25 / RainyDay

0 stars 1 forks source link

Please check if catalogNumba_irregular() is correct #54

Closed danielbwright closed 5 months ago

danielbwright commented 5 months ago

I'm doing some speed testing and the changes to this function look strange. Specifically, it doesn't use the domainmask at all, so I don't know how it could handle non-rectangular domains.

Ashar25 commented 5 months ago

I have changed the catalogNumba_irregular and it was really fast for me. I think I have discussed this changed with you. I am using domainmask before the function to get zeros where there is no domain in the rectangle. I am pretty sure the problem is with different libraries behaving differently with different versions.