Peer review 1 - ivy jochem

[ScarletIvy]

@AshleyNWagner @pawaitemadisoncollege

Design/Code Review 1

Project: Ashley Wagner Individual Project

Developer: Ashley Wagbner

Reviewer: Ivy Jochem

Item	Considerations	Comments/Suggestions
		Reviewer comments and suggestions go here. Each item should haveat least one "kudos" and two suggestions for improvement
Problem Statement	1. Accurately describes project purpose 2. Is professional and free of typos, slang, etc. 3. Fully explains the problem and the solution 4. Is understandable by the average person	+ Describes the project in a very easy to understand fashion, outlines the project in just a few sentances - I'd divvy up th second sentance into multiple, as is its a massive run on. other than that is pretty flawless
Design Documentation	1. Navigation/flow through the application is logical and easy to use. 2. The order in which values are displayed are logical and easy to understand/use 3. The order in which the form fields entered are logical and easy to understand/use 4. All data discussed/documented (problem statement, flow, db design, etc.) is represented on the screens	+ all of the sceen designs are really high quality, the user stories are really well layed out - the project plan sould probably be moved into the design documents folder, mvp tasks arent denoted super clearly
Data model/Database	1. Everything on the screens and problem statement/flow is represented in the model 2. There is at least one 1-to-many relationship. 3. The model represents good database design	+ the design is super easy to follow, code is clean and well formatted -comments are incomplete, not super required for this point in the projject though
Code	1. Proper Maven project structure is used 2. a .gitignore file for IntelliJ Java projects has been implemented 3. There is not any redundant or copy/paste code in the JSPs or classes 4. Classes are appropriately-sized (no monster classes) Property files are used appropriately: no hard-coded values 5. Logging statements are used rather than System.out.println and printStackTrace. 6. There are appropriate unit tests/code coverage.	+ all of the code is well layed out, jsp includes are used to minimize code duplication -some of the jsp pages thus far are just placeholders

[pawaitemadisoncollege]

@ScarletIvy and @AshleyNWagner Looks like some sneaky printlns and printStackTrace(): https://github.com/AshleyNWagner/IndieProject/search?q=print