AssessingSolar / unofficial-psm3-userguide

https://assessingsolar.github.io/unofficial-psm3-userguide
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Create page for numerical precision #10

Closed kandersolar closed 1 year ago

kandersolar commented 1 year ago

See https://github.com/AssessingSolar/unofficial-psm3-userguide/blob/precision/source/pages/numerical-precision.ipynb

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

AdamRJensen commented 1 year ago

Perhaps a bit premature, but why isn't the notebook shown in the table of content?

Also, might be visually nice to have the same order of the attributes lists :)

kandersolar commented 1 year ago

I wish the graph was sorted nicer, but I don't think it's worth sorting the columns again manually, and we might get it for free anyway once https://github.com/pvlib/pvlib-python/issues/1647 is resolved.

I suppose this is ready for review as I don't currently have plans to change the notebook further.