search

AssetSync / asset_sync

Synchronises Assets between Rails and S3
1.88k stars 346 forks source link

Removed files do not get flagged for deletion #440

Open julienbfabre opened 10 months ago

julienbfabre commented 10 months ago

In my initializer asset_sync.rb:

config.existing_remote_files = "delete"
config.remote_file_list_cache_file_path = File.join(Rails.root, 'data', 'asset_sync_remote_file_list_cache.json')
config.remote_file_list_remote_path = 'asset_sync_remote_file_list_cache.json'

after deleting some files i ran rake assets:precompile again but the deleted files were not flagged for deletion and remained in S3:

% rake assets:precompile
AssetSync: using /myapp/config/initializers/asset_sync.rb
AssetSync: Syncing.
Using: Directory Search of /myapp/public/assets
Downloading file list file from remote
Updating file list file in remote
Fetching files to flag for delete
Flagging 0 file(s) for deletion
AssetSync: Done.

I checked and the deleted files are still listed in data/asset_sync_remote_file_list_cache.json. What am i missing to get the deleted files to be noticed and removed from S3?

PikachuEXE commented 10 months ago

I don't use this gem so I have no idea how to figure out what goes wrong until there is a test case :S

julienbfabre commented 10 months ago

I don't use this gem so I have no idea how to figure out what goes wrong until there is a test case :S

@PikachuEXE i'm not i understand your reply, is there anything you need from me to help answer the question?

PikachuEXE commented 10 months ago

I have no idea how to reproduce it in test case(s) So I have no idea how to fix the issue