search

AssetSync / asset_sync

Synchronises Assets between Rails and S3
1.88k stars 346 forks source link

Run tests on rails8 #444

Closed shmokmt closed 1 week ago

shmokmt commented 1 week ago

Description

Ruby on Rails 8.0 is out. https://edgeguides.rubyonrails.org/8_0_release_notes.html

However, Rails8 requires Ruby 3.2 or higher version and latest jruby version is still Ruby 3.1 compatibility. Considering these, I excluded fail jobs. https://github.com/rails/rails/blob/5287cfa17681527761c50fd8c6ae169f4500bd97/rails.gemspec#L12 https://github.com/jruby/jruby/releases/tag/9.4.9.0

Thanks!

shmokmt commented 1 week ago

@PikachuEXE I checked that all tests passed. https://github.com/shmokmt/asset_sync/pull/1

PikachuEXE commented 1 week ago

Please help me update all 3.0 to "3.0" to ensure it really test 3.0 (otherwise parsed as 3 = latest 3.x) Also 3.0 need to be excluded

shmokmt commented 1 week ago

@PikachuEXE I fixed. Could you review again? https://github.com/AssetSync/asset_sync/pull/444/commits/f1f154582935a26608ad146f6d0224927f11d79e

All tests passed. https://github.com/shmokmt/asset_sync/actions/runs/11964151388/job/33355968682